search

zlsecure3 / review_star

0 stars 0 forks source link

code can be refined in `StarNameService.move` contract `renew_name_script` function #19

Open zlsecure3 opened 1 year ago

zlsecure3 commented 1 year ago

subject

code can be refined in StarNameService.move contract renew_name_script function

description

assert!(table::contains(&name_service_extension.gradient_fee_in_domainname, domain_name), GRADIENT_FEE_NOT_EXIST);
let fee_vector = table::borrow(&name_service_extension.gradient_fee_in_domainname, domain_name);

These 2 lines are always needed in both branches, no need to write the same code twice.

recommendation

Put the common code before the branch.

locations

severity

Informational

damage

exploitability

category

Code Style

system_generated: auditor:alansh submission_id:1465025044

zlsecure3 commented 1 year ago

grading (edit)

submission_id:1465025044

review_type:GRADING

result: TBD-yes,no

rating: TBD-123

comment: TBD-Rejected,Accepted by Secure3.

severity: TBD-Critical,Medium,Low,Informational

category:

description:

zlsecure3 commented 1 year ago

client feedback (manual copy)

submission_id:1465025044

review_type:CLIENT_FEEDBACK

result: TBD-yes,no

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 commented 1 year ago

client feedback decision(edit)

submission_id:1465025044

review_type:CLIENT_FEEDBACK_DECISION

result: TBD-yes,no,yes-honored,no-honored

severity: TBD-Critical,Medium,Low,Informational

comment: