code can be refined in `StarNameService.move` contract `create_name_script_nft` function

zlsecure3 commented 1 year ago

subject

code can be refined in StarNameService.move contract create_name_script_nft function

description

when name_services.temp_nft_vec doesn't contain owner, can insert vector:: singleton(name) and return directly.

recommendation

if (!table::contains(&mut name_services.temp_nft_vec, owner)) {
           table::add(&mut name_services.temp_nft_vec, owner, vector::empty());
        };

can be modified to:

if (!table::contains(&mut name_services.temp_nft_vec, owner)) {
           table::add(&mut name_services.temp_nft_vec, owner, vector:: singleton(name));
           return;
}

locations

./code/sources/StarNameService.move#L372-L374

severity

Informational

damage

exploitability

grading (edit)

submission_id:1465030899

review_type:GRADING

result: TBD-yes,no

rating: TBD-123

comment: TBD-Rejected,Accepted by Secure3.

severity: TBD-Critical,Medium,Low,Informational

category:

description:

zlsecure3 commented 1 year ago

client feedback (manual copy)

submission_id:1465030899

review_type:CLIENT_FEEDBACK

result: TBD-yes,no

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 commented 1 year ago

client feedback decision(edit)

submission_id:1465030899

review_type:CLIENT_FEEDBACK_DECISION

result: TBD-yes,no,yes-honored,no-honored

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 / review_star