search

zlsecure3 / review_star

0 stars 0 forks source link

Resource operation type usage error #36

Open zlsecure3 opened 1 year ago

zlsecure3 commented 1 year ago

subject

Resource operation type usage error

description

In the Move language, there are two ways to reference resources: borrow_global_mut and borrow_global. The borrow_global_mut operation is generally used to modify resource references, and borrow_global is generally used to read resources. So you only need to use the borrow_global operator when reading resources. However, in the check_prefix_length_isLegal, read_name_expire, read_name_owner, read_name_controller and read_name_resolver_contract functions of the StarNameService module, only the resource is read, but borrow_global_mut is used for the operation.

recommendation

It is recommended to use borrow_global when doing read operations on resources.

locations

severity

Informational

damage

exploitability

category

Code Style

system_generated: auditor:Kong7ych3 submission_id:1469203187

zlsecure3 commented 1 year ago

grading (edit)

submission_id:1469203187

review_type:GRADING

result: TBD-yes,no

rating: TBD-123

comment: TBD-Rejected,Accepted by Secure3.

severity: TBD-Critical,Medium,Low,Informational

category:

description:

zlsecure3 commented 1 year ago

client feedback (manual copy)

submission_id:1469203187

review_type:CLIENT_FEEDBACK

result: TBD-yes,no

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 commented 1 year ago

client feedback decision(edit)

submission_id:1469203187

review_type:CLIENT_FEEDBACK_DECISION

result: TBD-yes,no,yes-honored,no-honored

severity: TBD-Critical,Medium,Low,Informational

comment: