search

zlsecure3 / review_star

0 stars 0 forks source link

Code Style in `Airdrop` contract `consume` function #47

Open zlsecure3 opened 1 year ago

zlsecure3 commented 1 year ago

subject

Code Style in Airdrop contract consume function

description

The usage of assert is not standardized

recommendation

Assert is a builtin, macro-like operation provided by the Move compiler.Since the operation is a macro, it must be invoked with the !. reference link:https://move-language.github.io/move/abort-and-assert.html

locations

severity

Informational

damage

exploitability

category

Code Style

system_generated: auditor:yekong submission_id:1475534324

zlsecure3 commented 1 year ago

grading (edit)

submission_id:1475534324

review_type:GRADING

result: TBD-yes,no

rating: TBD-123

comment: TBD-Rejected,Accepted by Secure3.

severity: TBD-Critical,Medium,Low,Informational

category:

description:

zlsecure3 commented 1 year ago

client feedback (manual copy)

submission_id:1475534324

review_type:CLIENT_FEEDBACK

result: TBD-yes,no

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 commented 1 year ago

client feedback decision(edit)

submission_id:1475534324

review_type:CLIENT_FEEDBACK_DECISION

result: TBD-yes,no,yes-honored,no-honored

severity: TBD-Critical,Medium,Low,Informational

comment: