search

zlsecure3 / review_star

0 stars 0 forks source link

`supplied` never updated. #51

Open zlsecure3 opened 1 year ago

zlsecure3 commented 1 year ago

subject

supplied never updated.

description

When Airdriop::airdrop finished, credit_service.supplied should updated accordingly to indicate how much have been airdropped.

The impact is that more than the maxmium_supply amount can be airdropped if credit_service.supplied not being updated accordingly.

recommendation

update the credit_service.supplied in Airdriop::airdrop function.

credit_service.supplied += amount

locations

severity

Critical

damage

exploitability

category

Logic

system_generated: auditor:jayphbee submission_id:1464769086

zlsecure3 commented 1 year ago

grading (edit)

submission_id:1464769086

review_type:GRADING

result: TBD-yes,no

rating: TBD-123

comment: TBD-Rejected,Accepted by Secure3.

severity: TBD-Critical,Medium,Low,Informational

category:

description:

zlsecure3 commented 1 year ago

client feedback (manual copy)

submission_id:1464769086

review_type:CLIENT_FEEDBACK

result: TBD-yes,no

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 commented 1 year ago

client feedback decision(edit)

submission_id:1464769086

review_type:CLIENT_FEEDBACK_DECISION

result: TBD-yes,no,yes-honored,no-honored

severity: TBD-Critical,Medium,Low,Informational

comment: