search

zlsecure3 / review_star

0 stars 0 forks source link

check is incomplete in `StarNameService.move` contract `check_prefix_length_isLegal` function #57

Open zlsecure3 opened 1 year ago

zlsecure3 commented 1 year ago

subject

check is incomplete in StarNameService.move contract check_prefix_length_isLegal function

description

check_prefix_length_isLegal only checks against shortest length, it should also check against longest length to be complete.

recommendation

Also check against domain_to_longestlength.

locations

severity

Informational

damage

exploitability

category

Code Style

system_generated: auditor:alansh submission_id:1465040892

zlsecure3 commented 1 year ago

grading (edit)

submission_id:1465040892

review_type:GRADING

result: TBD-yes,no

rating: TBD-123

comment: TBD-Rejected,Accepted by Secure3.

severity: TBD-Critical,Medium,Low,Informational

category:

description:

zlsecure3 commented 1 year ago

client feedback (manual copy)

submission_id:1465040892

review_type:CLIENT_FEEDBACK

result: TBD-yes,no

severity: TBD-Critical,Medium,Low,Informational

comment:

zlsecure3 commented 1 year ago

client feedback decision(edit)

submission_id:1465040892

review_type:CLIENT_FEEDBACK_DECISION

result: TBD-yes,no,yes-honored,no-honored

severity: TBD-Critical,Medium,Low,Informational

comment: