zluca / Sidebar

WebExtension that imprement Sidebar into browser.
GNU General Public License v3.0
31 stars 9 forks source link

Suggestions #2

Open yfdyh000 opened 6 years ago

yfdyh000 commented 6 years ago
  1. "extDescription" to "Sidebar for Chromium and Firefox" or like "Sidebar panels".
  2. No option to disable the startpage?
  3. RSS Panel work?
  4. Some options (input-number) and the search engine list is covered in 1366*768, and more serious if adjusted layout.css.devPixelsPerPx.
  5. No context menu support. See also https://github.com/eoger/tabcenter-redux.
  6. The bookmark panel is stuck when there are 10k bookmarks.
zluca commented 6 years ago
  1. Agree
  2. Well, for now startpage hardcoded in the manifest and can not be disabled. I had experiments with injected startpage which can be disabled, but it works buggy in FF. But the main reason is that extension cannot inject iframe in startpage if it created by other extension or by default.
  3. Works for me. What browser you use?
  4. Accepted.
  5. not sure about this. Anyway first priority is to fix bugs. I will think about it later.
  6. Oo. I believe it because extension try to create fav icons for all of this bookmarks synchronically and it looks like "stuck". Need more experiments to check this theory. If you have time plz try to replace in "background.js" this line with newItem.domain = 'default';
yfdyh000 commented 6 years ago

Item 3: Firefox Nightly. "Add new RSS feed" button looks no effect, throw Error: Could not establish connection. Receiving end does not exist.. Well, I found the reason that it needs to load on the current page, you need to check the current page is not the privileged page (like about:addons) and use the notifications API to remind.

Item 6: Big improvement, just load takes a few seconds for the first start.

yfdyh000 commented 6 years ago

7: A plan to adding Add-ons management panel?

yfdyh000 commented 6 years ago

2: filled https://bugzilla.mozilla.org/show_bug.cgi?id=1420944

zluca commented 6 years ago

Well, I found the reason that it needs to load on the current page, you need to check the current page is not the privileged page (like about:addons) and use the notifications API to remind.

It should open new tab if current page is privileged, i remember that it works before, but now for some reason it broken. I will look into this. :/

Item 6: Big improvement, just load takes a few seconds for the first start.

Ok, thx for testing. Now i have a clue.

Allow users to control which one is enabled or all disabled for each chrome_url_overrides properties.

It would be nice if they implement this functionality.

7: A plan to adding Add-ons management panel?

No. ( If I correctly understand what you mean. =) )

zluca commented 6 years ago

@yfdyh000

  1. The bookmark panel is stuck when there are 10k bookmarks.

Can you tell me if it works better in latest version?

yfdyh000 commented 6 years ago

Can you tell me if it works better in latest version?

  1. 0.3.4. It takes many seconds when enableing, high CPU usage.
  2. If the bookmark panel is the last panel, it sometimes gets empty after it is enabled, Error: Could not establish connection. Receiving end does not exist. hundreds and the Search box's placeholder are undefined. Switch to another panel and switch back is work, switch back take about 2~5 seconds.
  3. Perhaps it is better to provides max result options? Such as show recent bookmarks only by default, max search results, max folders and sub-items, more... item to folder filter.
zluca commented 6 years ago

0.3.4.

plz test 0.3.5. ^^

Error: Could not establish connection. Receiving end does not exist

Yep, annoying thing.

show recent bookmarks only by default

Good idea, it can work! Tomorrow i will try.

yfdyh000 commented 6 years ago

0.3.5 looks no changes. You can copy and paste several times to get a lot of bookmarks for testing.

maverick74 commented 6 years ago

in Firefox I'm missing:

Synced Tabs Pocket List ScreenShoots

(in short, the items that are presented on Library)

Do any of this stand a chance???

zluca commented 6 years ago

@maverick74

Synced Tabs Pocket List

I need to make some research about this services. If they have good open API why not?

ScreenShoots

But why you need sidebar for making screenshots? There is a tons of extensions providing this feature.

maverick74 commented 6 years ago

@zluca

about ScreenShots: i'm referring to the link/webpage that is open when one goes to Menu>Library>Screenshots https://screenshots.firefox.com/shots which contains one's screenshots, not the app to take screenshots.

Pocket List goes the same way: it's, apparently, just a webpage.

In another words, Pocket List and ScreenShots, from what i understand, is just supposed to be a link/webpage that is open in the sidebar.

On the other hand Synced Tabs, i believe, is an app and not a webpage.

zluca commented 6 years ago

is just supposed to be a link/webpage

That's how it looks from user view. =) Screenshots and Pocket have a build-in extensions which doing the job invisibly for user.

From what i see Pocket is the main candidate to implement in next big release. But no promises. :)

maverick74 commented 6 years ago

LOL. It certainly looks pretty easy from where i stand. LOL

Looking forward for the improvements =)

zluca commented 6 years ago

@yfdyh000

2: filled https://bugzilla.mozilla.org/show_bug.cgi?id=1420944 Priority: -- → P5

Ok, lets face the truth this is never happen. 😃 But users ask me so much about disabling startpage so i will do it.

limon36 commented 6 years ago

yes because the all-in-one bar had it, the things on this list! But it had been disable due to the new firefox updates!

herbstgy commented 6 years ago

is it possible to set the refresh interval of the RSS feeds?

zluca commented 6 years ago

@herbstgy Options > Misc > RSS update period

herbstgy commented 6 years ago

@zluca great, thx.

EC-O-DE commented 6 years ago

Very good! Just what I was looking for (well vertical bookmarks bar (hover in/hover out)) but this seems promising. Worked in Opera without much glitch.

There's two ext's that u dev might find inspirational: Bookmarks Sidebar: https://chrome.google.com/webstore/detail/bookmark-sidebar/jdbnofccmhefkmjbkkdkfiicjkgofkdh?hl=en-US And: vTabs: https://chrome.google.com/webstore/detail/vtabs/okpnlgbgcfchbicbhjmmhldhkbkfilce?hl=en-US

edger78 commented 6 years ago

Open bookmark in new tab is really useful feature. Could you please implement it?

zluca commented 6 years ago

@edger78 You should hold Ctrl button to open bookmark in new tab, or Shift to open in new window.

edger78 commented 6 years ago

Yes, I know that, thanks, wheel click also works this way. But simple click is very welcome option. Not only me using that. Not sure if it's too complex to implement it.

zluca commented 6 years ago

@edger78 Ok now i got it. This option would be implemented, but no ETAs, because i need to finish current development.

edger78 commented 6 years ago

@zluca Thanks, sure. Take your time :) It's really great to have it finally.

herbstgy commented 6 years ago

Hi, is it possible to somehow delete the older items in the RSS feed? they just keep piling up ever since I installed the addon. (which I love by the way) image

zluca commented 6 years ago

@herbstgy Older rss items should be deleted automatically, there is an option in 'misc' section to set maximum items per feed. But for some reason it not work. Probably i broke something during last code refactor. Thx for reporting this bug.

zluca commented 6 years ago

@edger78 Check out 0.5.5 version.

edger78 commented 6 years ago

@zluca Hi, checked, no such option found - open bookmark in new tab. Default behavior the same.

On 31 March 2018 at 16:37, zluca notifications@github.com wrote:

@edger78 https://github.com/edger78 Check out 0.5.5 version.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zluca/Sidebar/issues/2#issuecomment-377693634, or mute the thread https://github.com/notifications/unsubscribe-auth/AV_HvNVcQIyJtbiQfCAJFgKTxsJI0Bd4ks5tj4axgaJpZM4QrVxc .

zluca commented 6 years ago

@edger78 Look to icon with 3 dots on the bottom of sidebar. :smiley:

edger78 commented 6 years ago

@zluca Wow, working like a charm!! Thank you, really appreciate your work!

On 31 March 2018 at 18:12, zluca notifications@github.com wrote:

@edger78 https://github.com/edger78 Look to icon with 3 dots on the bottom of sidebar. 😃

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zluca/Sidebar/issues/2#issuecomment-377699801, or mute the thread https://github.com/notifications/unsubscribe-auth/AV_HvOeupS0WOwGb7G6XM0vYN9RadY6uks5tj5zbgaJpZM4QrVxc .

zluca commented 6 years ago

@herbstgy Fixed in 0.5.6. Sidebar+ clean old rss items at startup now.

herbstgy commented 6 years ago

@zluca neat, thanks.

lrbloom commented 6 years ago

Is there a way to move the sidebar to the left side of the browser?

zluca commented 6 years ago

@lrbloom Of course. You can have even to sidebars right and left. Click to the extension icon on the top of the browser.

herbstgy commented 6 years ago

this new 0.5.9 version doesn't work well. i mean, it does not work at all. had to turn it off, because it prevents opening new pages. is there a way to revert to 0.5.8?

zluca commented 6 years ago

@herbstgy here Better revert to 0.5.7. I disable 0.5.8 and 0.5.9 cause it works strange in Firefox.

EC-O-DE commented 6 years ago

icons8-navigation-toolbar-left-96 icons8-navigation-toolbar-left-64 gallery if_64_sidebar_left_interface_menu_window_2142682 if_sidebar_left_interface_menu_window_1654369

^^^ Few icons for logo/inspiration. Btw: this is a rather good source: https://www.iconfinder.com/ Plenty of free ones.

herbstgy commented 6 years ago

now where have the autohide gone? (FF 60.0.1, Sidebar+ 0.5.11)

zluca commented 6 years ago

@herbstgy Should work. Unless you check "Manual switch" in misc options or pin sidebar.

herbstgy commented 6 years ago

@zluca no, sorry. I checked the option you mentioned, it is turned off. For some reason, autohide still not works. Anything else I should check?

zluca commented 6 years ago

@herbstgy Check if you use Iframe sidebar and it is not pinned.

herbstgy commented 6 years ago

I do use Iframe sidebar (tried to switch it back and forth a couple of times). Where can I check the other? I do remember a pin icon from somewhere... but now i can't find it.

herbstgy commented 6 years ago

also, links don't open with a single click now... only with right click+open in new tab. I'm thinking on an uninstall/reinstall magic now.

zluca commented 6 years ago

I do remember a pin icon from somewhere... but now i can't find it.

Icon should be at the top of sidebar.

herbstgy commented 6 years ago

okay. the uninstall/reinstall magic worked. now everything works again as it supposed to. (I've found the pin icon too :) ) but I lost my rss feeds in the process. :) can you tell me here can i find the subscribed rss folder in the profiles? I have backup, I can restore them from there.

zluca commented 6 years ago

@herbstgy

By the way i suddenly remember this situation. If sidebar injected with old version of Sidebar+ and then update it loose connection with background script. So you have to update page.

zluca commented 6 years ago

can you tell me here can i find the subscribed rss folder in the profiles?

Im afraid the is no folder. But you can export rss feeds to opml file.

herbstgy commented 6 years ago

too late, i lost them with the reinstall... :)

kenreeser commented 6 years ago

Sidebar+ is an excellent sidebar extension—well done zluca. To make it even better, I'd like like the ability to open all bookmarks contained within a bookmark folder simultaneously via a newly added icon added to each lowest level bookmark folder. I'm moving away from sessions and back to bookmarks because sessions aren't available on phones (because phone developers won't allow the use of browser extensions on mobile browsers). With the addition of my requested feature, I'll be able to treat folders of bookmarks more like sessions (sort of).