zluca / Sidebar

WebExtension that imprement Sidebar into browser.
GNU General Public License v3.0
31 stars 9 forks source link

Iframe sidebar sometimes overlaps other content #35

Open Su-Well opened 5 years ago

Su-Well commented 5 years ago

I've seen this on several sites, the most recent in memory being youtube.com, where Sidebar+ is on top of youtube's menu on the left: image

It's my opinion that this isn't really Sidebar+'s fault, but rather the fault of bad CSS on the offending websites. Case in point, even youtube's own devs refers to the overlapping element's CSS as: image

Nevertheless, it is our problem. I've played around with Sidebar+'s and youtube's CSS a little, but have as of yet been unable to find a solution I'm confident can be generalized to all sites. I'm not very skilled at CSS, but here are some things that come to mind as far as solutions go:

I'd be happy to put in some work on this, but I figure that I should at least get your thoughts on this first @zluca.

zluca commented 5 years ago

Problem is that the more you touch site CSS the more chance to broke something. In earlier versions of Sidebar+ we had more aggressive CSS inception and it destroy some sites functionality.

One of the ways is to make a specific CSS rules for the most popular sites like Youtube to adopt it for Sidebar+.