search

zlzeng / DeepFloorplan

GNU General Public License v3.0
270 stars 103 forks source link

Jurassic Python #5

Open ricardo-reis-1970 opened 4 years ago

ricardo-reis-1970 commented 4 years ago

Dear authors,

This is a great piece of code and I thank you for it. My question is: why Python 2.7? The timestamp on your paper shows 2019. Python 3.0 dates back to December 2008, and Python 2 was put on death row 5 years ago, seriously looking like 2020 will be the year of the final execution.

Is this due to some library being tied to Python 2.7?

Are you planning on porting this to 3? If not, could I please try and do it myself? My plan would be to:

  1. humbly try to port it;
  2. submit it to you for checking;
  3. keep mention to your authorship at all times.

Again, many thanks. Ricardo

chiboreache commented 4 years ago

Tensorflow 2 would be also nice ;)

andrew-begain commented 4 years ago

Dear authors,

This is a great piece of code and I thank you for it. My question is: why Python 2.7? The timestamp on your paper shows 2019. Python 3.0 dates back to December 2008, and Python 2 was put on death row 5 years ago, seriously looking like 2020 will be the year of the final execution.

Is this due to some library being tied to Python 2.7?

Are you planning on porting this to 3? If not, could I please try and do it myself? My plan would be to:

  1. humbly try to port it;
  2. submit it to you for checking;
  3. keep mention to your authorship at all times.

Again, many thanks. Ricardo

@ricardo-reis-1970 Excuse me, have you changed the version to python3? If so, can you send me a copy?Thank you. My email is 987413972@qq.com

zcemycl commented 3 years ago

@ricardo-reis-1970 @andrew-begain @chiboreache I just rewrote part of the codes into python3 and tf2, view it in https://github.com/zcemycl/TF2DeepFloorplan .

andrew-begain commented 3 years ago

@ricardo-reis-1970 @andrew-begain I just rewrote part of the codes into python3 and tf2, view it in https://github.com/zcemycl/TF2DeepFloorplan .

its great .thank you very much!