zmalltalker / sketch-android-assets

Generate Android assets in Sketch
GNU General Public License v3.0
356 stars 55 forks source link

Default size assumption should be MDPI (or customisable) #21

Closed mrrocks closed 10 years ago

mrrocks commented 10 years ago

At least, in Google we design using 1px = 1dp, MDPI.

zmalltalker commented 10 years ago

This makes sense, I'm thinking it should be some kind of setting. Would it make sense if this was a per user setting, or should it be per document? On Jul 28, 2014 11:26 AM, "Fran Pérez" notifications@github.com wrote:

At least, in Google we design using 1px = 1dp, MDPI.

— Reply to this email directly or view it on GitHub https://github.com/zmalltalker/sketch-android-assets/issues/21.

mrrocks commented 10 years ago

Not sure, probably per document would be more flexible.

zmalltalker commented 10 years ago

I just pushed a version which lets you specify a different px<->dp setting, the README has a new section: https://github.com/zmalltalker/sketch-android-assets#base-resolution-experimental

Would you mind trying this out and see how that works for you, @mrrocks?

zmalltalker commented 10 years ago

I just added a dialog with a dropdown list of the available density buckets where you can select which one to use as the base density for your current document. This can still be overridden with a “user global” configuration file or by altering the config file by hand. But any selection you make in this dialog will be saved in the expected format and used as the base resolution.

mrrocks commented 10 years ago

I think the dialog is a really good solution :+1:

Thanks a lot :)

zmalltalker commented 10 years ago

Great! Does it work the way you expected?

mrrocks commented 10 years ago

Works like a charm, thank you :)

On Wed Aug 06 2014 at 7:41:06 AM Marius Mathiesen notifications@github.com wrote:

Great! Does it work the way you expected?

— Reply to this email directly or view it on GitHub https://github.com/zmalltalker/sketch-android-assets/issues/21#issuecomment-51299100 .

zmalltalker commented 10 years ago

:thumbsup: