search

zmalltalker / sketch-android-assets

Generate Android assets in Sketch
GNU General Public License v3.0
356 stars 55 forks source link

Update for Sketch 3 support? #9

Closed ip00 closed 10 years ago

ip00 commented 10 years ago

Do you plan to update this plugin for Sketch 3? Although there is better Export in Sketch 3 I would still use it. ETA?

caidentity commented 10 years ago

Would love this, can't seem to find a single tool to support sketch 3

zmalltalker commented 10 years ago

Hmm, I just checked, and the plugin should work with Sketch 3. One thing that has changed since version 2 is the location of the Sketch plugins directory. I just updated the Install section of the README with some notes about this.

zmalltalker commented 10 years ago

However, let me know if you find any imcompatibilities and I'll do my best to resolve them.

richardgazdik commented 10 years ago

I always get the same error log in console: "Support/com.bohemiancoding.sketch3/Plugins/Generate Android Assets.jstalk): TypeError: 'undefined' is not a function (evaluating 'page. allSlices()')". It seems that both slices and allSlices methods are unsupported at the moment.

ip00 commented 10 years ago

I can't export anything from Sketch 3. Everything was working fine in 2, though. Plugin is installed correctly but Plugins > sketch-android-assets-master > Generate Android Assets > Open - does nothing. DIP to PX converter is working.

In Console log same as richardgazdik wrote:

30.04.14 17:19:26,841 Sketch[2448]: Sketch-Scripting Error on Line 46 (/Users/xx/Library/Application Support/com.bohemiancoding.sketch3/Plugins/sketch-android-assets-master/Generate Android Assets.jstalk): TypeError: 'undefined' is not a function (evaluating 'page. allSlices()')

zmalltalker commented 10 years ago

The error message you mentioned suggests that this problem could have been resolved in #10 Mind trying to pull and see if that helps?