search

zmap / zcrypto

Liberal Go TLS + X.509 Library for Research
Other
135 stars 83 forks source link

issuer_dn, subject_dn unnecessary escaping #319

Open chushuai opened 3 years ago

chushuai commented 3 years ago

https://github.com/zmap/zcrypto/blob/30e1a9e0a8f5a3711cfd10ffb695da3ffb178321/x509/pkix/pkix.go#L232

image

zakird commented 3 years ago

I looked at the RFC and what ZCrypto is doing is indeed correct. We have to escape the character in the field to build the DN and JSON also dictates that the escaped comma must also be escaped.

On Sun, Sep 26, 2021 at 3:57 AM cy @.***> wrote:

https://github.com/zmap/zcrypto/blob/30e1a9e0a8f5a3711cfd10ffb695da3ffb178321/x509/pkix/pkix.go#L232

[image: image] https://user-images.githubusercontent.com/5875458/134804740-797e4140-d81e-42e0-b96c-2ce68cf3cfdb.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zmap/zcrypto/issues/319, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABREUFSWPM5QTSVW6ET7QLUD34CZANCNFSM5EYVF4NQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.