zakird
commented
1 year ago No objections. Makes sense to me
On Tue, Oct 24, 2023 at 2:38 AM Rob @.***> wrote:
There's currently an effort to add lints to zlint to test for the various rules from the new (ish) SMIME BR certificates. Many of these lints will be checking the subject.EmailAddress field however creating test data is a bit of a pain because the zcrypto/x509.CreateCertificate function doesn't include anything specified in pkix.Name-EmailAddress fields in the marshalled ASN.1. It won't be a difficult fix, just adding another line to Name.ToRDNSequence() (x509/pkix/pkix.go#268).
I'm happy to make the change+PR but I thought it'd be worth creating an issue about this first before opening the PR in case anyone has a firm objection to this whole idea!
— Reply to this email directly, view it on GitHub https://github.com/zmap/zcrypto/issues/373, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABREUB4U2NULI66KBWACALYA6EC5AVCNFSM6AAAAAA6NMZM6CVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2TQOBXG4ZDEMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
There's currently an effort to add lints to zlint to test for the various rules from the new (ish) SMIME BR certificates. Many of these lints will be checking the subject.EmailAddress field however creating test data is a bit of a pain because the zcrypto/x509.CreateCertificate function doesn't include anything specified in pkix.Name-EmailAddress fields in the marshalled ASN.1. It won't be a difficult fix, just adding another line to Name.ToRDNSequence() (x509/pkix/pkix.go#268).
I'm happy to make the change+PR but I thought it'd be worth creating an issue about this first before opening the PR in case anyone has a firm objection to this whole idea!