search

zmap / zgrab2

Fast Go Application Scanner
Other
1.75k stars 307 forks source link

[MERGED] Consider adding a "Portable" cipher-suite shorthand/profile #285

Closed mzpqnxow closed 3 years ago

mzpqnxow commented 3 years ago

There is more detail on this in https://github.com/zmap/zcrypto/issues/236 but the gist is that it would be nice to:

  1. Extend the compatibility of zgrab2 SSL/TLS negotiation
  2. Accomplish that without requiring users to specify a long list of cipher-suite identifieres using --cipher-suite

This would essentially be a change in zcrypto to add something like PortableCiphers (similar to ChromeCiphers, SafariCiphers, etc) and then a one line change in zgrab2 in the map that is used when looking at --cipher-suite parameters with values like safari-only, chrome-only, etc.

A PR supporting this effort is already merged in zcrypto. There is now a PR available for the zgrab2 side

Thanks!

mzpqnxow commented 3 years ago

zgrab2 PR #302 has been merged, thank you!