zmap / zgrab2

Fast Go Application Scanner
Other
1.75k stars 307 forks source link

jarm: update jarm to not fail on handshake failure #328

Closed aspacewalz closed 3 years ago

aspacewalz commented 3 years ago

This PR removes the error handling for a JARM probe response. The reason is that a handshake failure should still be processed the same as any other response. Currently a handshake failure results in the ZeroHash value being returned. This does not match the salesforce jarm module which should be treated as the correct implementation.

After this change, the salesforce and zgrab2 modules will both return the same fingerprint for services that return a handshake failure to one of the probes.

How to Test

go test ./...

Notes & Caveats

This PR is being created to bring the zgrab2 JARM module in line with the behavior of the salesforce jarm tool.