search

zmap / zgrab2

Fast Go Application Scanner
Other
1.71k stars 294 forks source link

Fix tests and boundary condition #410

Closed Seanstoppable closed 3 months ago

Seanstoppable commented 6 months ago

https://github.com/zmap/zgrab2/pull/375/files caused two tests to fail: truncate_read_header tls_truncate_read_header

Because now we skip a block if we have EOF errors I added a bunch of additional tests to try to confirm we'd break for a bunch of other weird cases This turns up a potential issue where we hit an EOF and because of golang defaults, we actually return a success.

I'm not entirely sure if these are expected behavior, but minimally this highlights some perhaps unexpected side effects from the mentioned PR.

Seanstoppable commented 6 months ago

@ycamper probably should have pinged you when I originally made this, but was wondering your thoughts about these test failures that came up after the merge of your PR.

Seanstoppable commented 4 months ago

@phillip-stephens at some point, wondering if you could help review this PR as well. Not entirely sure if this is correct/expected behavior, but would love to get back to all tests passing