zmap / zgrab2

Fast Go Application Scanner
Other
1.71k stars 294 forks source link

Please bump the Golang version to a modern one #440

Closed yurivict closed 1 week ago

yurivict commented 3 months ago

here

Errors:

# golang.org/x/sys/unix
vendor/golang.org/x/sys/unix/syscall.go:82:16: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/syscall_bsd.go:247:20: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
vendor/golang.org/x/sys/unix/syscall_unix.go:117:7: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)
developStorm commented 3 months ago

@phillip-stephens thoughts?

phillip-stephens commented 3 months ago

Yeah we should def do this. I started it here, but something is going wrong in the integration tests. I need to take some time and figure out how these integration tests are working to know what I broke. 😭

mzpqnxow commented 1 month ago

Yeah we should def do this. I started it here, but something is going wrong in the integration tests. I need to take some time and figure out how these integration tests are working to know what I broke. 😭

Do these tests pass with the current master, without changes? I vaguely recall there being some issues with CI though I don't recall of they were specifically related to validation of the output against the schemas

Something to check, before you bang your head too much against the wall 😊

Seanstoppable commented 2 weeks ago

@phillip-stephens I just realized I did a similar thing as you in #461, but integration tests pass just fine there. Looking at your own PR, it looks pretty much all the containers failed on crypto related items (you'll see errors in docker container execution). Since you didn't change any of them, perhaps a failure stemming from whatever was running the integration tests, rather than an issue with the change itself?

mzpqnxow commented 2 weeks ago

I added a note to the test failure, in case it saves you a few minutes in identifying where the actual ERROR is

Seems like a NULL value is not being serialized/deserialized from a dict into the expected custom int class

phillip-stephens commented 1 week ago

Closed with #461. Thanks @Seanstoppable !