Closed yurivict closed 1 week ago
@phillip-stephens thoughts?
Yeah we should def do this. I started it here, but something is going wrong in the integration tests. I need to take some time and figure out how these integration tests are working to know what I broke. ðŸ˜
Yeah we should def do this. I started it here, but something is going wrong in the integration tests. I need to take some time and figure out how these integration tests are working to know what I broke. ðŸ˜
Do these tests pass with the current master, without changes? I vaguely recall there being some issues with CI though I don't recall of they were specifically related to validation of the output against the schemas
Something to check, before you bang your head too much against the wall 😊
@phillip-stephens I just realized I did a similar thing as you in #461, but integration tests pass just fine there. Looking at your own PR, it looks pretty much all the containers failed on crypto related items (you'll see errors in docker container execution). Since you didn't change any of them, perhaps a failure stemming from whatever was running the integration tests, rather than an issue with the change itself?
I added a note to the test failure, in case it saves you a few minutes in identifying where the actual ERROR is
Seems like a NULL value is not being serialized/deserialized from a dict
into the expected custom int class
Closed with #461. Thanks @Seanstoppable !
here
Errors: