search

zmap / zlint

X.509 Certificate Linter focused on Web PKI standards and requirements.
https://zmap.io
Apache License 2.0
358 stars 109 forks source link

AlgorithmIdentifier encoding (Section 7.1.3.1, CAB-Forum BR) #642

Closed mtgag closed 2 years ago

mtgag commented 3 years ago

This pull request adds a lint for Section 7.1.3.1 of CAB BR (introduced in v1.7.1 - https://cabforum.org/wp-content/uploads/CA-Browser-Forum-BR-1.7.1.pdf), in particular regarding the encoding of AlgorithmIdentifier for public keys. This lints is related to lint_mp_ecdsa_pub_key_encoding_correct.go. Please consider the lint for inclusion in zlint project.

mtgag commented 2 years ago

I briefly wanted to ask whether this pull request is still considered for inclusion? Is there somethig to do on our side?

christopher-henderson commented 2 years ago

(thank you for your patience, the repo went largely silent over the holidays)

@mtgag the code changes still look good to me, and @sleevi I believe it looks like your comments were addressed.