search

zmap / zlint

X.509 Certificate Linter focused on Web PKI standards and requirements.
https://zmap.io
Apache License 2.0
353 stars 107 forks source link

Add close-primes detection via Fermat's factorization #673

Closed vanbroup closed 2 years ago

vanbroup commented 2 years ago

zlint is currently missing a close-primes lint, maybe we can repurpose the check from boulder for this?

https://github.com/letsencrypt/boulder/commit/89000bd61cfc6f373cb48b6f046d4fce7df5468e

https://fermatattack.secvuln.info/

cc: @aarongable

aarongable commented 2 years ago

Happy for the boulder implementation to be reused for this, but I don't currently have time to put together the zlint PR myself, sorry!

vanbroup commented 2 years ago

No problem, thanks for letting this code be used. I can work on this in a few weeks (currently on vacation).

christopher-henderson commented 2 years ago

@aarongable @vanbroup the change listed in Boulder is reasonably contained (and commented) so I can take a crack at this. Although, I may enlist Aaron (or at least @ mention them) in the PR for a smoke check

aarongable commented 2 years ago

Should this bug be considered fixed/closed, or is there more work to do now that #674 has been merged?