search

zmap / zlint

X.509 Certificate Linter focused on Web PKI standards and requirements.
https://zmap.io
Apache License 2.0
353 stars 107 forks source link

Add new lint to block organisational unit names as of 1st September 2022 #675

Closed robplee closed 2 years ago

robplee commented 2 years ago

I've attempted to address #628. ~I took a guess at what the appropriate version number for the BRs will be but please let me know if I've guessed wrong.~ (Nevermind, I realised that the version of the document is not as important as the rule change has a particular date mentioned and I can just describe that instead of a version number for the BRs) I ran make integration -overwriteExpected to try and get an entry in the config.json record for the new lint but it didn't seem to change the file so I think I might have made a mistake somewhere but I can't work out where as it looks right to me...

So far, I've just tackled the easy bit of SC47 and banned them utterly from 1st September. I'll try to suss out the combination rules and add a rule effective sooner but I am less certain if that's needed if it's outright banned in September but I'll see what I can work out from the PR Corey linked in the issue he opened.

Also, I'm English so can reviewers be extra careful to check that I've correctly, incorrectly spelled "organizational" across all the files I've added/changed 😄

mtgag commented 2 years ago

This issue is also related to https://github.com/zmap/zlint/pull/643.

christopher-henderson commented 2 years ago

outright banned in September but I'll see what I can work out from the PR Corey linked in the issue he opened.

I'll attempt to fix the merge conflict in that one and re-engage people on it.

check that I've correctly, incorrectly spelled "organizational"

I had to look this one up. I had no idea that this was (yet another) subtle difference :stuck_out_tongue:

robplee commented 2 years ago

@christopher-henderson - any updates on this vs the #643 PR? It's been approved for three weeks so it seems a shame not to merge.

christopher-henderson commented 2 years ago

@robplee the primary reason was because Sleevi had some objections that I was interesting in understanding if they were addressed, however we gave not heard from him in the project for awhile.