test.ReadTestCert breaks for downstream consumers dependent on the previous relative certificate path building behavior

zmap / zlint

X.509 Certificate Linter focused on Web PKI standards and requirements.

https://zmap.io

Apache License 2.0

353 stars 107 forks source link

test.ReadTestCert breaks for downstream consumers dependent on the previous relative certificate path building behavior #695

Closed christopher-henderson closed 1 year ago

christopher-henderson commented 1 year ago

A change was made in https://github.com/zmap/zlint/commit/e5ee614b989dca0615c7fdb9cb6d621f281c5a20#diff-47c0d21c7e2125d3727429db1028c23a261ce73c25250dc176cb68bf666d7a23L73 wherein the path to find test certificates was changed to be absolute from the root of the repo.

This made it easier to run the tests from any location in the repo, however it broke some downstream consumers who were dependent upon this relative path construction.

Fixes #696