zmap / zlint

X.509 Certificate Linter focused on Web PKI standards and requirements.
https://zmap.io
Apache License 2.0
353 stars 107 forks source link

Always perform e_cert_unique_identifier_version_not_2_or_3 #711

Closed mtgag closed 1 year ago

mtgag commented 1 year ago

Lint e_cert_unique_identifier_version_not_2_or_3 checks whether the unique identifier(s) is present and then checks that the version is correct. Lint lint_cert_extensions_version_not_3.go takes another approach. It always performs the linting and the check is done during execution as one step. Both are very similar cases and the implementation could be aligned. Proposal: always perform e_cert_unique_identifier_version_not_2_or_3 and check inside the execution the presence and correct values. (Alternatively align lint_cert_extensions_version_not_3 to the approach of e_cert_unique_identifier_version_not_2_or_3.)