search

zmap / zlint

X.509 Certificate Linter focused on Web PKI standards and requirements.
https://zmap.io
Apache License 2.0
349 stars 108 forks source link

Include LintMetadata in the LintResult #729

Closed aaomidi closed 11 months ago

aaomidi commented 1 year ago

This reduces the need to do a lookback on what the lint was based on its name when all the user needs is the metadata.

This also allows the name field in the results to be eventually sunset.

aaomidi commented 11 months ago

I didn't really think about if we want it in JSON or not when writing this and was following the rest of the fields. No opinions on it either way and I'm happy to exclude it from JSON serialization.

I don't see harm in this being included though either as the metadata is effectively only a bunch of strings.

dadrian commented 11 months ago

I think the JSON output would be extremely redundant when ran with ZCertificate if LintMetadata was included, so let's leave it out of the JSON.