All lints need tests

[dadrian]

We should have a meta-test, that enforces that any lint file has an associated test file.

[zakird]

I went through and looked at which lints don't have tests by name. Here is the list that we should investigate:

• [ ] lint_generalized_time_does_not_include_seconds.go [no censys]
• [ ] lint_generalized_time_includes_fraction_seconds.go [no censys]
• [ ] lint_subject_not_dn.go
• [ ] lint_dh_params_missing.go [no censys]
• [ ] lint_rsa_no_public_key.go [no censys]
• [ ] lint_qcstatem_qcretentionperiod_valid.go
• [ ] lint_qcstatem_qcsscd_valid.go
• [ ] lint_subject_dn_serial_number_not_printable_string.go
• [x] ~lint_subject_locality_without_org.go~
• [x] ~lint_dsa_improper_modulus_or_divisor_size.go~
• [x] ~lint_subject_province_without_org.go~
• [x] ~lint_ext_authority_key_identifier_no_key_identifier.go~
• [x] ~lint_subject_common_name_disallowed.go~

[zakird]

In case it helps, this is the code I used to check:

import sys

e = set()
for l in sys.stdin:
    l = l.strip()
    if "test" not in l:
        e.add(l)
    else:
        l = l.replace("_test", "")
        e.remove(l)

print e