search

zmap / zlint

X.509 Certificate Linter focused on Web PKI standards and requirements.
https://zmap.io
Apache License 2.0
349 stars 108 forks source link

Calling CheckApplies in Test Context #758

Closed cardonator closed 8 months ago

cardonator commented 8 months ago

Is there a benefit we could gain by calling CheckApplies in a testing context? Currently, the framework only calls lint.Execute when testing which works well for scenarios where you're trying to test certs that may not pass CheckApplies (such as certs generated by the build in cert generator). However, it seems like this is leaving a gap where CheckApplies behavior is not actually tested for each lint.

Any thoughts?

cardonator commented 8 months ago

Oops, I misread the flow of logic and this isn't actually an issue. Sorry!