search

zmap / zlint

X.509 Certificate Linter focused on Web PKI standards and requirements.
https://zmap.io
Apache License 2.0
363 stars 109 forks source link

Convert all Lint to CertificateLint #766

Closed aaomidi closed 1 year ago

aaomidi commented 1 year ago

Solves #765

Generation code: https://github.com/aaomidi/zlint-migration

The formatting isn't...what I exactly wanted it to be. I'm still trying to see if I can go directly to a well formatted struct and not have to run gofmpt on everything.

I've asked about the formatting issue: https://groups.google.com/g/golang-nuts/c/C16T4H7slA4

aaomidi commented 1 year ago

@zakird, I'm curious since you're a major maintainer here. Would you accept the formatting of the RegisterCertificateLint methods as is, or should I try to spend some more time getting the formatting just right?

Also just curious, how do you feel about the fact that I ended up running gofumpt on all of these lints?

aaomidi commented 1 year ago

Well, I actually think I have a correct solution in #767 now