The module's max_packet_length is used for accurately computing the send rate to stay under any user-given bandwidth limitations.
This bug meant that the packet length was only accurate for the case where no TCP options were used (--probe-args="none") and incorrect for all other options.
Testing
Before fix, --probe-args="windows" -B 1G and --probe-args="linux" -B 1G would give the same send rate on a non-bandwidth constrained system, even though windows sends 8 bytes less per probe packet.
After fix, the same test results in 1.34 Mpps for windows and 1.24 Mpps for linux.
The module's
max_packet_lengthis used for accurately computing the send rate to stay under any user-given bandwidth limitations.This bug meant that the packet length was only accurate for the case where no TCP options were used (
--probe-args="none") and incorrect for all other options.Testing
Before fix,
--probe-args="windows" -B 1Gand--probe-args="linux" -B 1Gwould give the same send rate on a non-bandwidth constrained system, even thoughwindowssends 8 bytes less per probe packet.After fix, the same test results in
1.34 Mppsforwindowsand1.24 Mppsforlinux.