cmake doesn't check for Judy.h

zmap / zmap

ZMap is a fast single packet network scanner designed for Internet-wide network surveys.

https://zmap.io

Apache License 2.0

5.43k stars 907 forks source link

cmake doesn't check for Judy.h #882

Closed yurivict closed 3 months ago

yurivict commented 3 months ago

Describe the bug

cmake succeeds and the build then fails:

cmake should check all dependencies.

Environment:

OS: FreeBSD 14.0
Version: 4.1.1

phillip-stephens commented 3 months ago

IMO, I'm not sure this is a bug but rather a potential enhancement. It'd be nice if CMake would give the user a nice message about how Judy wasn't found and how to install. But INSTALL.md (which is referenced in the README.md) does mention exactly what you need to install to compile this from source.

I'll take a look at getting this into CMake though since it would improve the user experience.

yurivict commented 3 months ago

cmake can easily check for the header with CHECK_INCLUDE_FILE.