zmartzone / lua-resty-openidc

OpenID Connect Relying Party and OAuth 2.0 Resource Server implementation in Lua for NGINX / OpenResty
Apache License 2.0
963 stars 247 forks source link

1.7.6 not released to openresty package manager #488

Open Clivern opened 1 year ago

Clivern commented 1 year ago

Hi there, I think you didn't release the latest version 1.7.6 to opm yet! not sure if that was intentional. Also this commit is needed https://github.com/zmartzone/lua-resty-openidc/commit/4b9316403e1d6a162aecea86c466f50fe78232e8 to be released since new installs will give bungle/lua-resty-session v4 which doesn't work with zmartzone/lua-resty-openidc ---> https://github.com/zmartzone/lua-resty-openidc/issues/480 https://github.com/zmartzone/lua-resty-openidc/issues/464

Environment
Expected behaviour

1.7.6 should be available for new installs / upgrades and release this commit https://github.com/zmartzone/lua-resty-openidc/commit/4b9316403e1d6a162aecea86c466f50fe78232e8

Actual behaviour
$ opm info zmartzone/lua-resty-openidc
Name             : lua-resty-openidc
Version          : 1.7.5
Abstract         : A library for NGINX implementing the OpenID Connect Relying Party (RP) and the OAuth 2.0 Resource Server (RS) functionality
Author           : Hans Zandbelt (@zandbelt)
Account          : zmartzone
Code Repo        : https://github.com/zmartzone/lua-resty-openidc
License          : Apache License 2.0
Original Work    : yes
Requires         : openresty, ledgetech/lua-resty-http >= 0.13, bungle/lua-resty-session >= 2.8, cdbattags/lua-resty-jwt >= 0.2.0
kr4sv commented 1 year ago

Readme states the following: Older versions of lua-resty-openidc could also be installed using opm but this is no longer supported.

Clivern commented 11 months ago

Readme states the following: Older versions of lua-resty-openidc could also be installed using opm but this is no longer supported.

Well, I meant 1.7.6 not published on opm https://opm.openresty.org/package/zmartzone/lua-resty-openidc/. Indeed you can install old versions!

$ opm get zmartzone/lua-resty-openidc=$version
idlefella commented 11 months ago

I also wanted to ask for the reason why the plugin isn't anymore released on opm. On the openresty website, they even say that using luarocks is highly discouraged:

WARNING! This page is deprecated. Use of LuaRocks with OpenResty is strongly discouraged since OpenResty provides its own package manager, OPM.

https://openresty.org/en/using-luarocks.html

Clivern commented 11 months ago

I also wanted to ask for the reason why the plugin isn't anymore released on opm. On the openresty website, they even say that using luarocks is highly discouraged:

WARNING! This page is deprecated. Use of LuaRocks with OpenResty is strongly discouraged since OpenResty provides its own package manager, OPM.

https://openresty.org/en/using-luarocks.html

Just noticed that! they even switched on purpose https://github.com/zmartzone/lua-resty-openidc/commit/66d285071de5c7749cd2dfd051e9bf0fa37732aa https://github.com/zmartzone/lua-resty-openidc/issues/17

justin-octo commented 1 month ago

A year later... still not released.

# opm info zmartzone/lua-resty-openidc
Name             : lua-resty-openidc
Version          : 1.7.5
Abstract         : A library for NGINX implementing the OpenID Connect Relying Party (RP) and the OAuth 2.0 Resource Server (RS) functionality
Author           : Hans Zandbelt (@zandbelt)
Account          : zmartzone
Code Repo        : https://github.com/zmartzone/lua-resty-openidc
License          : Apache License 2.0
Original Work    : yes
Requires         : openresty, ledgetech/lua-resty-http >= 0.13, bungle/lua-resty-session >= 2.8, cdbattags/lua-resty-jwt >= 0.2.0
justin-octo commented 1 month ago

Any way to install 1.7.6 manually somehow?

kr4sv commented 1 month ago

Any way to install 1.7.6 manually somehow?

https://github.com/zmartzone/lua-resty-openidc?tab=readme-ov-file#installation

justin-octo commented 1 month ago

I appreciate you taking the time to comment. Unfortunately, RTFM type comments are not as helpful as we all may wish them to be when the manual is filled with contradicting information.

I think I had some luck with:

Manually installing luarocks:

wget http://luarocks.org/releases/luarocks-3.11.1.tar.gz
tar -xzvf luarocks-3.11.1.tar.gz
cd luarocks-3.11.1/
./configure --prefix=/usr/local/openresty/luajit \
    --with-lua=/usr/local/openresty/luajit/ \
    --lua-suffix=jit \
    --with-lua-include=/usr/local/openresty/luajit/include/luajit-2.1
make
sudo make install

And then installing the specific version of lua-resty-openidc=1.7.6

luarocks install lua-resty-openidc=1.7.6

But it still was missing the .so files (not just wrong path, but nowhere in the system), and many other files.

024/08/13 17:10:55 [error] 100257#100257: *7376 lua entry thread aborted: runtime error: access_by_lua(conf.d/custom.co
nf:159):30: module 'resty.openidc' not found:
        no field package.preload['resty.openidc']
        no file '/usr/local/openresty/resty/openidc.lua'
        no file '/usr/local/openresty/site/lualib/resty/openidc.ljbc'
        no file '/usr/local/openresty/site/lualib/resty/openidc/init.ljbc'
        no file '/usr/local/openresty/lualib/resty/openidc.ljbc'
        no file '/usr/local/openresty/lualib/resty/openidc/init.ljbc'
        no file '/usr/local/openresty/site/lualib/resty/openidc.lua'
        no file '/usr/local/openresty/site/lualib/resty/openidc/init.lua'
        no file '/usr/local/openresty/lualib/resty/openidc.lua'
        no file '/usr/local/openresty/lualib/resty/openidc/init.lua'
        no file './resty/openidc.lua'
        no file '/usr/local/openresty/luajit/share/luajit-2.1/resty/openidc.lua'
        no file '/usr/local/share/lua/5.1/resty/openidc.lua'
        no file '/usr/local/share/lua/5.1/resty/openidc/init.lua'
        no file '/usr/local/openresty/luajit/share/lua/5.1/resty/openidc.lua'
        no file '/usr/local/openresty/luajit/share/lua/5.1/resty/openidc/init.lua'
        no file '/usr/local/openresty/site/lualib/resty/openidc.so'
        no file '/usr/local/openresty/lualib/resty/openidc.so'
        no file './resty/openidc.so'
        no file '/usr/local/lib/lua/5.1/resty/openidc.so'
        no file '/usr/local/openresty/luajit/lib/lua/5.1/resty/openidc.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
        no file '/usr/local/openresty/site/lualib/resty.so'
        no file '/usr/local/openresty/lualib/resty.so'
        no file './resty.so'
        no file '/usr/local/lib/lua/5.1/resty.so'
        no file '/usr/local/openresty/luajit/lib/lua/5.1/resty.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'

For example, the openidc.so was no where on the system.

justin-octo commented 1 month ago

I guess I'll open another issue instead of hijacking this one.