search

zmb3 / godoc

Deprecated - use https://atom.io/packages/go-plus instead
MIT License
4 stars 1 forks source link

this.goget.register is not a function #43

Closed jjeffery closed 7 years ago

jjeffery commented 7 years ago

[Enter steps to reproduce below:]

  1. Start Atom
  2. Update 12 packages (tester-go 2.0.2, navigator-godef, linter 1.11.18, language-protobuf 0.7.0, gorename 1.1.0 gometalinter-linter 1.2.2 gofmt 1.2.0 go-plus 4.3.2 go-get 2.1.1 go-config 1.2.4 builder-go 1.0.1 auto-complete-go 1.3.0)
  3. Wait a minute so, then get two error messages. One error message indicates that an issue has already been created (#42), another indicates that a new issue should be created.
  4. Clicking the "Create issue on the navigator-go package" button has no effect.

Atom Version: 1.11.1 Electron Version: 0.37.8 System: Microsoft Windows 10 Pro Thrown From: navigator-go package, v1.1.3

Stack Trace

Failed to activate the navigator-go package

At this.goget.register is not a function

TypeError: this.goget.register is not a function
    at Object.registerTool (C:/Users/jjeffery/.atom/packages/navigator-go/lib/main.js:68:39)
    at Object.consumeGoget (C:/Users/jjeffery/.atom/packages/navigator-go/lib/main.js:61:10)
    at Provider.module.exports.Provider.provide (C:\Users\jjeffery\AppData\Local\atom\app-1.11.1\resources\app.asar\node_modules\service-hub\lib\provider.js:29:52)
    at ServiceHub.module.exports.ServiceHub.consume (C:\Users\jjeffery\AppData\Local\atom\app-1.11.1\resources\app.asar\node_modules\service-hub\lib\service-hub.js:50:18)
    at Package.module.exports.Package.activateServices (C:\Users\jjeffery\AppData\Local\atom\app-1.11.1\resources\app.asar\src\package.js:363:75)
    at Package.module.exports.Package.activateNow (C:\Users\jjeffery\AppData\Local\atom\app-1.11.1\resources\app.asar\src\package.js:186:16)
    at C:\Users\jjeffery\AppData\Local\atom\app-1.11.1\resources\app.asar\src\package.js:156:32
    at Package.module.exports.Package.measure (C:\Users\jjeffery\AppData\Local\atom\app-1.11.1\resources\app.asar\src\package.js:92:15)
    at C:\Users\jjeffery\AppData\Local\atom\app-1.11.1\resources\app.asar\src\package.js:149:26
    at Package.module.exports.Package.activate (C:\Users\jjeffery\AppData\Local\atom\app-1.11.1\resources\app.asar\src\package.js:146:34)
    at PackageManager.module.exports.PackageManager.activatePackage (C:\Users\jjeffery\AppData\Local\atom\app-1.11.1\resources\app.asar\src\package-manager.js:538:21)
    at C:\Users\jjeffery\.atom\packages\autocomplete-go\node_modules\atom-package-deps\lib\helpers.js:28:30
    at Array.map (native)
    at C:\Users\jjeffery\.atom\packages\autocomplete-go\node_modules\atom-package-deps\lib\helpers.js:27:43
    at undefined.next (native)
    at step (C:\Users\jjeffery\.atom\packages\autocomplete-go\node_modules\atom-package-deps\lib\helpers.js:45:273)
    at process._tickCallback (internal/process/next_tick.js:103:7)

Commands

     -2:06.5.0 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)

Config

{}

Installed Packages

# User
autocomplete-go, v1.3.0 (active)
builder-go, v1.0.1 (active)
editorconfig, v1.4.1 (active)
go-config, v1.2.4 (active)
go-debug, v0.1.22 (inactive)
go-get, v2.1.1 (active)
go-plus, v4.3.2 (active)
godoc, v1.1.0 (inactive)
gofmt, v1.2.0 (active)
gometalinter-linter, v1.2.2 (active)
gorename, v1.1.0 (active)
language-ini, v1.16.0 (active)
language-protobuf, v0.7.0 (active)
linter, v1.11.18 (active)
navigator-go, v1.1.3 (inactive)
navigator-godef, v1.0.3 (active)
tester-go, v1.0.4 (inactive)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.44.0 (inactive)
base16-tomorrow-dark-theme, v1.2.0 (inactive)
base16-tomorrow-light-theme, v1.2.0 (inactive)
one-dark-ui, v1.6.0 (active)
one-light-ui, v1.6.0 (inactive)
one-dark-syntax, v1.3.0 (active)
one-light-syntax, v1.3.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.7.0 (active)
archive-view, v0.61.1 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.11.2 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.1 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.42.0 (active)
bracket-matcher, v0.82.1 (active)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.201.1 (inactive)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.59.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.1 (inactive)
markdown-preview, v0.158.0 (active)
metrics, v1.0.0 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.242.2 (active)
snippets, v1.0.2 (active)
spell-check, v0.68.2 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.0 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.101.0 (active)
timecop, v0.33.2 (active)
tree-view, v0.209.3 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.33.0 (active)
wrap-guide, v0.38.2 (active)
language-c, v0.52.1 (active)
language-clojure, v0.21.0 (active)
language-coffee-script, v0.47.2 (active)
language-csharp, v0.12.1 (active)
language-css, v0.37.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.42.1 (active)
language-html, v0.45.1 (active)
language-hyperlink, v0.16.0 (active)
language-java, v0.23.0 (active)
language-javascript, v0.119.0 (active)
language-json, v0.18.2 (active)
language-less, v0.29.5 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.35.0 (active)
language-php, v0.37.2 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.0 (active)
language-ruby, v0.69.0 (active)
language-ruby-on-rails, v0.25.0 (active)
language-sass, v0.56.0 (active)
language-shellscript, v0.22.4 (active)
language-source, v0.9.0 (active)
language-sql, v0.23.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.28.0 (active)
language-toml, v0.18.0 (active)
language-xml, v0.34.9 (active)
language-yaml, v0.26.0 (active)

# Dev
No dev packages
jjeffery commented 7 years ago

image

zmb3 commented 7 years ago

Please see #36 and #42. Just restart Atom and you should be all set. This is just package updates occurring out of order.

joefitzgerald commented 7 years ago

@zmb3 why not just check for the function?

if (this.goget && this.goget.register) { this.goget.register(...) }

zmb3 commented 7 years ago

@joefitzgerald not a bad idea - i will do that (even though it doesn't really fix anything - we won't be properly registered with go-get until after a restart)