search

zmb3 / spotify

A Go wrapper for the Spotify Web API
Apache License 2.0
1.34k stars 284 forks source link

Respect proper handling of context.Context #143

Closed strideynet closed 3 years ago

strideynet commented 3 years ago

Whilst this would require a severely breaking API change, a case can be made for a v2 release that allows the user to provide a context as the first argument of requests. This allows cancellations to propagate correctly.

zmb3 commented 3 years ago

Yep! This package predates the context package, but I would welcome a PR to do just what you describe. It would provide the opportunity to fix some other things too given a new major version.

I don’t personally have a need or desire to undertake this, but if somebody wanted to do the work I’d love to see it and would be happy to help.

strideynet commented 3 years ago

@zmb3, I've seen a few of the tickets and have an idea of what other things to include in a breaking release.

One thing that did occur to me is that if you are wanting to step away from this project, is that potentially my fork could proceed as v2 once it is complete and that this repository could be marked as deprecated.