search

zmb3 / spotify

A Go wrapper for the Spotify Web API
Apache License 2.0
1.34k stars 284 forks source link

Add ExchangeWithOpts to be used with pkce authentication #146

Closed ialbors closed 3 years ago

ialbors commented 3 years ago

So we can set "code_verifier" param url without needing an HTTP request.

zmb3 commented 3 years ago

@strideynet is actually working on a v2 branch right now with better options support. Let's make sure to get this feature included there.

ialbors commented 3 years ago

Is there anything I could do about it?

Should I open a pull request against the other branch (if not already included)?

Thanks.

strideynet commented 3 years ago

I can't see the harm in this particular change being made directly to master here as part of the 1.0 release series, and I'll merge master back into the v2 branch once that's been done :)

I'm doing an overall review as part of 2.0 to make the auth client and the api client more configurable, and this will probably fit nicely into that.