zmb3 / spotify

A Go wrapper for the Spotify Web API
Apache License 2.0
1.38k stars 291 forks source link

Fix spelling of a JSON key #155

Closed exp625 closed 3 years ago

exp625 commented 3 years ago

The JSON key for the item object in the CurrentlyPlaying struct is now in lowercase. See https://developer.spotify.com/documentation/web-api/reference/#endpoint-get-the-users-currently-playing-track

strideynet commented 3 years ago

Thank you, has all appropriate test data been corrected as well?

exp625 commented 3 years ago

Looks like the test data already uses the lowercase spelling for item: https://github.com/zmb3/spotify/blob/9f0fbd9ccd0d25c1cabebd1023a693d8d67845b7/test_data/player_currently_playing.txt#L5

The only occurrence of "Item" for the json key I found was in https://github.com/zmb3/spotify/blob/adbbf425dd35c4dcac21a8ffff2ce8a2d9af800a/player.go#L63

strideynet commented 3 years ago

Awesome, thanks.