search

zmb3 / spotify

A Go wrapper for the Spotify Web API
Apache License 2.0
1.38k stars 294 forks source link

PlaybackOffset Position field is updated from int to *int #177

Closed omerhanci closed 1 year ago

omerhanci commented 2 years ago

Hi, after the fix mentioned here: https://github.com/zmb3/spotify/issues/161 playing with the PlaybackOffset URI parameter seems to be broken.

Although Position parameter is not set, since it has a default value 0 and there is no omitempty, it's always sent to spotify api. So that changing it to some nullable type and adding omitempty again seems to fix the issue here.

strideynet commented 2 years ago

Hi @omerhanci, I'll review this tonight thank you.

strideynet commented 1 year ago

This was resolved in another PR.