zmb3 / spotify

A Go wrapper for the Spotify Web API
Apache License 2.0
1.33k stars 284 forks source link

Add GetPlaylistItems #189

Closed xonstone closed 2 years ago

xonstone commented 2 years ago

For getting all tracks (both episode and track types) of a playlist

Web API ref: https://developer.spotify.com/documentation/web-api/reference/#/operations/get-playlists-tracks

xonstone commented 2 years ago

Nice work ! We should move towards suggesting users switch to this method from GetPlaylistTracks.

Can you:

  • Add a deprecation comment to the GetPlaylistTracks method
  • Include test data for a playlist with both a track and a episode
  • Export the AdditionalTypes option, and fall back to providing both types if the user doesn't provide AdditionalTypes they desire? I essentially want this method to return both, unless the user explicitly states they just want one type.

I implemented all the mentioned changes as well.

strideynet commented 2 years ago

Really nice work, thank you <3