search

zmb3 / spotify

A Go wrapper for the Spotify Web API
Apache License 2.0
1.37k stars 287 forks source link

Remove unnecessary pointers from structs #61

Closed andrewpillar closed 6 years ago

andrewpillar commented 6 years ago

This is definitely going to be a breaking change for the people using this library. I ran the tests and they all passed after the changes I had made.

andrewpillar commented 6 years ago

I think creating a new branch to merge this change into would be a smart thing to do. Then you could use gopkg.in.

zmb3 commented 6 years ago

I think creating a new branch to merge this change into would be a smart thing to do. Then you could use gopkg.in.

@andrewpillar can you update the pull request to merge into a new branch and not master?

andrewpillar commented 6 years ago

@zmb3 sure I can, but I can currently only edit this pull request to merge into either master or v1.

zmb3 commented 6 years ago

@andrewpillar I created a v2 branch so that you can merge into that.