search

zmb3 / spotify

A Go wrapper for the Spotify Web API
Apache License 2.0
1.39k stars 291 forks source link

Support for "client credentials" flow. #83

Closed jdelfino closed 6 years ago

jdelfino commented 6 years ago

Originally reported in: https://github.com/zmb3/spotify/issues/37. The workaround posted there does not allow the token to be automatically refreshed -oauth2.clientcredentials.Config.Client() must be used to create the Client.

Open to a better name for this method :)

zmb3 commented 6 years ago

I agree the name feels odd. How about NewClientWithCredentials?

jdelfino commented 6 years ago

Yeah, not perfect, but at least less wordy. Thanks!

zmb3 commented 6 years ago

If you have a better idea, last chance before I click the big green merge button.. 😛

jdelfino commented 6 years ago

Can't think of any better name - did you mean to close without merging?

zmb3 commented 6 years ago

Not at all. I’ll reopen and merge.

On Mon, Oct 8, 2018 at 11:57 AM Joe Delfino notifications@github.com wrote:

Can't think of any better name - did you mean to close without merging?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/zmb3/spotify/pull/83#issuecomment-427925054, or mute the thread https://github.com/notifications/unsubscribe-auth/AHLav4GHl0BW4n6uStv0Mwk2XVXHp5fyks5ui5H-gaJpZM4XNDac .

franciscocpg commented 4 years ago

Why this one didn't get merged? :thinking: