search

zmbush / coffeelint-ruby

This adds some simple bindings to ruby to enable use of coffeelint
MIT License
32 stars 23 forks source link

Update Coffeelint to 1.0.2 #6

Closed brianmcallister closed 10 years ago

brianmcallister commented 10 years ago

Pointed this at the latest Coffeelint tag.

zmbush commented 10 years ago

Please test your PR before committing it.

brianmcallister commented 10 years ago

Duh! Sorry about that. It looks like there were some changes made to coffeelint causing JS errors. Not too sure how to handle it within the tests though. Strange, considering I'm able to lint stuff without error.

zmbush commented 10 years ago

Huh. that is strange. The problem is that there used to be one file coffeelint.coffee, and now it's split into several files.

Zachary Bush zmbush.com http://www.zmbush.com

On Wed, Dec 18, 2013 at 11:59 AM, Brian McAllister <notifications@github.com

wrote:

Duh! Sorry about that. It looks like there were some changes made to coffeelint causing JS errors. Not too sure how to handle it within the tests though. Strange, considering I'm able to lint stuff without error.

— Reply to this email directly or view it on GitHubhttps://github.com/zipcodeman/coffeelint-ruby/pull/6#issuecomment-30875032 .

brianmcallister commented 10 years ago

Ah, now I understand (this is the first time I've worked with the coffeelint project). So, it looks like it's also depending on Node.js or being processed by Browserify. Maybe a good solution would be also include browserify as another submodule, and then run coffeelint through that?

zmbush commented 10 years ago

Hey @brianmcallister in case you're curious, I finally got around to updating the coffeelint version. the newest gem v0.2.0 is running v1.0.6 of coffeelint.