Adding 'ruby news' aggregations - sound good?

[zmcartor]

To show off more parsing and data handling, I'm adding another section to the site that will be an aggregate scrape of 'ruby news' from various sources around the web.

I'd like to show off more data requesting/parsing/transformation code.

Sound good to everyone ?

[mattyoho]

If that sounds fun to you, go for it. We'll be analyzing and critiquing the code, but by far your best bet is to implement something you find interesting to do.

Doing something with either persistence or interesting front-end presentation would also be advantageous.

[zmcartor]

Hi Matt,

I've decided to build on what I already have with the scraper and add some aggregation + persistence with MongoDB. Links and images will be submitted and up/down voted. Submission will happen via the img/link scraping. Voting will happen via another list that will show submitted links+images per day. Different days can be selected as well as a 'HOT' section will all time high image/link upvotes.

Thoughts ?

[mattyoho]

Sounds like a fine approach to me.

[zmcartor]

Cool. I've implemented some persistance with Mongo and a page of 'recommended' imgs with vote scores. Adding simple voting functionality as well.

Would you like to see more advanced parsing/scraping ?

Project has taken an interesting turn , never used a scrape + vote service before. Pictures are interesting when removed from their context.

[zmcartor]

HI Matt,

Updated the branch and added up/down voting. Realized I had 0 tests, so need to get that taken care of as well! ;) Looking for feedback on my code or if you would like to see anything else done or re-factored.

Thanks, _Z

[mattyoho]

Definitely a good catch that you need some tests. ;-) We spend a large portion of our time doing TDD/BDD style development. I regret not getting you more specific feedback sooner, but I'm on vacation in Puerto Rico and have been traveling. I'll take a look this evening and start to give some more pointed commentary.

Thanks for continuing to iterate.

[zmcartor]

Hi Matt,

Wow very nice, hope it was a good trip!

I'm a fan of TDD but sometimes forget about it in the early stages of prototyping a personal project until I get a feel for which direction I'm going in. (when I'm the only collaborator, that is.)

Safe travels, _Zach

On Mon, Oct 31, 2011 at 3:44 PM, Matt Yoho < reply@reply.github.com>wrote:

Definitely a good catch that you need some tests. ;-) We spend a large portion of our time doing TDD/BDD style development. I regret not getting you more specific feedback sooner, but I'm on vacation in Puerto Rico and have been traveling. I'll take a look this evening and start to give some more pointed commentary.

Thanks for continuing to iterate.

Reply to this email directly or view it on GitHub: https://github.com/zmcartor/lordinateuramuse/issues/2#issuecomment-2582176

[zmcartor]

Hi Matt,

Added some tests and will continue adding more later today.

best, _Zach

[mattyoho]

Sounds good. I had just cloned the repo and started going through it, so I'll pull the latest. Thanks.

[zmcartor]

HI Matt,

Thanks very much for all the feedback. I'll be refactoring things this evening.

Regarding 'TODOs' in the code , I like to leave those in as a contextual reminder (if appropriate) as well as long in the issue list. I've removed them and put into README like you suggested.

Regarding subclassing Sinatra::Base - kinda like not polluting the JS namespace ;) haven't used this approach much, but I see how it makes a big difference in testing. I like how the app can be carried around in just a buttond up class now.

best, _Z

[zmcartor]

Hi Matt, What's your opinion on 'require' path management ? relative_require , the big ugly require File.join(File.dirname(FILE), '..', 'stuff.rb') or just $LOAD_PATH << '.'