search

zmcewen / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

SUMMARY #5

Open rimmesbe opened 7 years ago

rimmesbe commented 7 years ago

Grade: Satisfactory

Summary: Nice job on this project, it looks really good on desktop and mobile. Lots of good technique usage here. Try to keep your html looking pristine (indent correctly, elements on their own lines if not inline, etc.). Your class names are ok but they are a little short, don't be afraid of making more verbose class names. Check out some of the popular css selector naming conventions, like BEM: http://getbem.com/introduction/ Overall really nice job, hope you enjoyed the course, seems like you've learned a lot.

zmcewen commented 7 years ago

Thanks Rimmesbe,

Some really great pointers there, i'll be sure to take them onboard for future projects.