search

zmeers / ggparliament

Simple parliament plots using ggplot2
https://zmeers.github.io/ggparliament/
Other
150 stars 13 forks source link

New geoms #17

Closed zmeers closed 6 years ago

zmeers commented 6 years ago

I think we can push this to the master branch, pending your okay. It's a lot cleaner than the master branch at this point and has several new functions. Just a quick note about the helper functions - we'll want to remove the export, won't we? No need for users to have access to it..

RobWHickman commented 6 years ago

cool- gone through all the code changes and I'll probs change some small things and try and simplify the code down a bit where theres some redundancy but I don't think theres anything that should hold up a pull.

Going to spend tomorrow lunch/evening going through the vignettes to do a final check and then I'll pull across

zmeers commented 6 years ago

Hey -- if you can double check the aes(type=type) stuff, that would be awesome! One issue I've spotted is if you don't load +draw_majoritylabel() or whatever a warning pops up sayng that the type is not defined (because it's not needed for geom_parliament_seats(). Thanks.

RobWHickman commented 6 years ago

I was having trouble building the package which was solved by removing collate from the DESCRIPTION file as per https://github.com/klutometis/roxygen/issues/485. Seems like everything is still working but just fyi

(also added the data name to data.R to allow loading of election_data easily)

RobWHickman commented 6 years ago

ok, gone through the vignettes, made a few changes: