zmilla93 / SlimTrade

A trade UI overlay for Path of Exile
MIT License
133 stars 15 forks source link

POE Client Path #22

Closed herrfresch closed 4 years ago

herrfresch commented 4 years ago

Cant change the POE Client Path! If i klick on one folder, the window closes

zmilla93 commented 4 years ago

What version of SlimTrade are you using? Also is this happening in the options menu, or during setup when you set the client file for the first time?

The folder select window is supposed to disappear if you click outside of POE or SlimTrade, but should reappear when tabbing back in. There is a graphical bug when doing this that could make the open window appear all white, but is fixed by closing and reopening the folder select window.

The issue of the folder select window permanently disappearing has existed in old versions, but has since been patched and doesn't occur for me in the latest version.

herrfresch commented 4 years ago

hi, i use 0.2.7 when i open the SlimTrade.jar and then want to change the path under settings, the window comes up, but as soon as i want to click on a folder, slim trade disappears and the window turns white and stays white.

zmilla93 commented 4 years ago

Sounds like it is the graphics bug I described, but it is occurring all the time for you rather than just when tabbing out. I assume this is what it looks like?

Thank for the report, I'll look for a fix for this.

In the mean time, if you want to keep using the program you can manually edit SlimTrade's settings.json file to update the client path, just be careful to change the right thing and not accidentally delete an extra quote or comma.

The worst case scenario of doing this incorrectly is corrupting the save file, which just means SlimTrade will delete and remake it on launch. Inconvenient, but it won't actually break anything.

zmilla93 commented 4 years ago

I realize why this might be happening. When you click the edit button, what is the title of the folder select window shown here?

If it isn't "Open", SlimTrade will think you are tabbing of the game and hide the overlay. This may not work on non Windows, and almost certainly won't work if not using English as your system language. Let me know if this is the issue and I'll start testing out a fix.

herrfresch commented 4 years ago

Hello, the title is open, but as soon as i click on something, the window turns white, yes the system language is german

zmilla93 commented 4 years ago

I assume it is the German word for "Open" and not English? The check I use currently looks for the exact phrase "Open", so I'd have to manually add the equivalent phrase for all languages. I'd much rather look for a solution that will work regardless of language.

Did manually editing the client path work for you? It should allow you to use the program until I can come up with a proper solution. Thanks for the report, sorry for the inconvenience!

zmilla93 commented 4 years ago

Fixed in v0.2.9.