zmilla93 / SlimTrade

A trade UI overlay for Path of Exile
MIT License
122 stars 13 forks source link

Insufficient delay before second enter press under certain circumstances #54

Open jackhamilton opened 2 years ago

jackhamilton commented 2 years ago

Describe the bug Second enter press occurs too quickly, resulting in the clipboard being pasted into chat but not actually submitted. Fairly consistently replicable with my setup.

image [Capture via Carnac of inputs sent. The enter event is properly sent, but a higher delay is necessary, as the client has not finished responding to the open chat/paste events.]

Reproduce

  1. Open game in borderless fullscreen using the official client (not steam)
  2. Map hideout to F5
  3. Go to menagerie
  4. Press F5
  5. Behavior is observable most of the time for me with the hideout macro. Also occurs in trade, but not always. Probably dependent on system load.

Setting SlimTrade Version: 3.1 Operation System: Windows 10 21H1 Awakened POE Trade running alongside

jackhamilton commented 2 years ago

Wanted to note that the trade functionality is the first app to actually work properly for me, since every other one I've tried (including Mercury) had buttons that only worked like half the time or so. Thanks for the work :)

jackhamilton commented 2 years ago

Don't quite remember Java limitations, but you could adjust enter delay automatically based on CPU load. Alternatively, just make it configurable. I'm almost certain a like 50ms delay option would fix this, since that's what I've had to do in my AHK scripts for similar issues.

zmilla93 commented 2 years ago

Thanks for the detailed post, very useful. I'll take look into adding a delay where needed, likely an opt in option with a checkbox. Will try and include it in the next patch, though that may not be until next league.

Any reason you are on v0.3.1? The latest version is v0.3.5, and the app should update itself on restart. Hopefully the updater isn't broken.

jackhamilton commented 2 years ago

thanks, appreciate it! And yeah, turns out I am on 0.3.5, I think I was looking at the Carnac version instead of slimtrade, lmao. My mistake.