search

zmkfirmware / zmk

ZMK Firmware Repository
https://zmk.dev/
MIT License
2.79k stars 2.82k forks source link

nibble underglow and nice!nano v2 support #1583

Closed jhsu closed 1 year ago

jhsu commented 1 year ago

When trying to enable underlgow with nibble board + nice!nano v2, i'm getting a build error as it can't determine the number of leds: https://github.com/jhsu/zmk-config/actions/runs/3681553747/jobs/6228473449

shouldn't "underglow" be listed in features? https://github.com/zmkfirmware/zmk/blob/f03e29ca135fb41644cbae40b9233ba7adce4153/app/boards/shields/nibble/nibble.zmk.yml

caksoylar commented 1 year ago

Looks like this is the same issue as https://github.com/zmkfirmware/zmk/issues/885. You can try the workarounds in the issue such as copying the overlay into your keymap or #include it like #include <../boards/shields/nibble/boards/nice_nano.overlay>.

jhsu commented 1 year ago

yep! that seems to have been the issue. closing as this is a duplicate.