zmkfirmware / zmk

ZMK Firmware Repository
https://zmk.dev/
MIT License
2.67k stars 2.74k forks source link

fix(ci): checkout repository for get-changed-files #2343

Closed xudongzheng closed 3 months ago

xudongzheng commented 3 months ago

Not sure if/how this was working before without the checkout but all the recent commits that touch app/src seem to fail on get-changed-files.

A few recent examples:

This fixes test failures such as https://github.com/zmkfirmware/zmk/actions/runs/9618851916/job/26533624945.

xudongzheng commented 3 months ago

Glad to see I'm not the only one that noticed this issue.

Ideally your commit with improvements included will get merged soon but I'll keep this open for now in case it gets reviewed more quickly since it's an isolated change.

petejohanson commented 3 months ago

Closing since #2262 is now merged.