fix(macro): set the macro release states wait_ms

zmkfirmware / zmk

ZMK Firmware Repository

https://zmk.dev/

MIT License

2.67k stars 2.74k forks source link

fix(macro): set the macro release states wait_ms #2357

Open SolidHal opened 3 months ago

SolidHal commented 3 months ago

when we create a release trigger state for each press state we miss setting the releases wait_ms field, resulting in key releases all occuring instantaneously

this can result in lost key release commands see issue #2356

logs testing this fix are posted in the linked issue

caksoylar commented 3 months ago

It might be nice to add a test for this, perhaps?

I just noticed it also fails one of the tests anyway, so that would need to be handled.