zmkfirmware / zmk

ZMK Firmware Repository
https://zmk.dev/
MIT License
2.58k stars 2.63k forks source link

Bug: Wakeup is broken for matrix integrated soft-off #2376

Closed Nick-Munnich closed 2 weeks ago

Nick-Munnich commented 1 month ago

2283 broke waking from soft-off for matrix integrated hardware soft-off. Specifically, commit 0438cb0 breaks it - waking works fine for commits prior to it, and breaks on commits following it.

Shield used for testing is here, a simple breadboard shield. Related comment on Discord is here.

lesshonor commented 1 month ago

so, that commit sneaks a brand new attribute into kscan-sideband-behaviorsauto-enable—which your shield does not appear to have. I'm not sure what the purpose of it is, but if it isn't set basically the entire init gets skipped. One of the sideband examples in the soft-off docs was updated as well (though the other was left alone...)

If you haven't already done so locally, please try adding it.

Nick-Munnich commented 1 month ago

Unfortunately auto-enable does not fix the issue, I'd tried that previously (and just double-checked to be sure). The direct pin setup will completely break without auto-enable, but it does not seem to make a difference for the matrix-integrated setup. EDIT FOR CLARIFICATION: With auto-enablesoft-off works fine in the direct pin case, and it still works fine to enter soft-off in the matrix case. It's only the waking up using direct pins attached to the matrix that's broken.

Nick-Munnich commented 2 weeks ago

Closed by #2399.