zmkfirmware / zmk

ZMK Firmware Repository
https://zmk.dev/
MIT License
2.82k stars 2.85k forks source link

CMD & Shift Mod-Taps cause weird behaviors in correlation with combos. #713

Closed waffle87 closed 3 years ago

waffle87 commented 3 years ago

Board: Nice!Nano Shield: CRKBD User Repo: https://github.com/ItsWaffIe/zmk-config

Shift Issues

Using shifted mod taps with keys used in combos cause the combo key to be spammed and if the combo key is shifted, caps lock becomes enabled but can't be turned off. This is fixed by resetting each half. In the video below, it was Shift + Y which is a combo on TY which outputs " : ". Example

CMD/Control Issues

I've tried multiple keycodes and all have resulted in this issue. The CMD keycode seems to get combined with whatever key I press next. In the video below, it was CMD + T. Example

okke-formsma commented 3 years ago

image

your videos are still on private mode?

I don't really understand what you're exactly doing. Can you tell me what sequence of keys you press, and how they're configured?

e.g.

waffle87 commented 3 years ago

your videos are still on private mode?

Oops, fixed the video issue, sorry.

I don't really understand what you're exactly doing. Can you tell me what sequence of keys you press, and how they're configured?

Shift example: I have &mt LSHFT A and a combo that output &kp COLON when &kp T and &kp Y are pressed. If I hold &mt LSHFT A to get shift and press &kp T or &kp Y, it spams &kp COLON until I type other characters which are also now shifted and the only way to fix that is by resetting the controller.

Command example: I have &mt RCMD FSLH and if I were to press any other key, like &kp S for example, Command & S remain held until the controller is reset.

okke-formsma commented 3 years ago

I think this will be fixed by https://github.com/zmkfirmware/zmk/pull/697. Can you set your west.yml to point to my branch and flash that firmware to test? (guide: https://deploy-preview-711--zmk.netlify.app/docs/features/under-development/)

waffle87 commented 3 years ago

Yep, seems to work nicely now. Thank you for your work.