search

zmkfirmware / zmk

ZMK Firmware Repository
https://zmk.dev/
MIT License
2.74k stars 2.78k forks source link

`zmkfirmware/zmk-config-template`: `zephyr-modules` cache key's `west.yml` path incorrect #851

Open innovaker opened 3 years ago

innovaker commented 3 years ago

https://github.com/zmkfirmware/zmk-config-template/blob/main/.github/workflows/build.yml

key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('manifest-dir/west.yml') }}

hashFiles('manifest-dir/west.yml') looks like a hangover from an earlier version/attempt.

The caching still functions, but is likely to be sub-optimum following Zephyr upgrades until the cache expires.

caksoylar commented 2 years ago

Will be fixed by #1183.