search

zmoazeni / csscss

A CSS redundancy analyzer that analyzes redundancy.
http://zmoazeni.github.io/csscss/
MIT License
2.92k stars 151 forks source link

Added support for LESS dynamic CSS #52

Closed mekka closed 11 years ago

mekka commented 11 years ago

All tests pass, and I added a few more tests for the CLI to verify that we can correctly parse LESS and SASS files as well as CSS. The SASS test stylesheet specifically covers the shorthand format. I also did some minor refactoring on cli.rb to make it easier to test, and bring down the complexity of the execute method.

LESS is an optional dependency, so users don't need to install the LESS gem if they're not going to use it. LESS tests are skipped if the LESS gem is not installed.

I merged all the latest changes from master before this pull request, so all the refactored stuff and bug fixes are already in.

cheers

zmoazeni commented 11 years ago

@mekka Thanks! I really appreciate you taking the time to put together the PR. There are a few things that I want to tweak, and I want to squash this all into one commit. So I'll probably close this PR unmerged and bring in the relevant bits. I'll give you a heads up once it is in master though.

zmoazeni commented 11 years ago

Closing unmerged. Thanks again.

mekka commented 11 years ago

Cool beans. I looked at the changes you made and they all make sense. Good point on squashing.

Keyboardist commented 11 years ago

My English is poor, this passage is Bing translation, so there are many problems in the configuration. Does not use this site, are my reasons.Thank you, I will try to study English.